Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing views with empty editor area slow, shows paint artifacts #710

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

iloveeclipse
Copy link
Member

  • don't add listener that resizes composite to paint events, there are too many of them, and one shouldn't try to resize/set bounds on paint, that can only cause more paint events
  • use CTabFolder2Listener.itemsCount to update on editor open/close
  • use control listener to get updates on resize

Fixes #708

Requires first SWT change eclipse-platform/eclipse.platform.swt#621

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

Test Results

     819 files  ±0       819 suites  ±0   43m 9s ⏱️ + 1m 43s
  5 660 tests ±0    5 504 ✔️ ±0  143 💤 ±0    9 ±0  4 🔥 ±0 
18 126 runs  ±0  17 658 ✔️ +2  454 💤 +1  10  - 3  4 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 0f4dbb6. ± Comparison against base commit 8f35528.

♻️ This comment has been updated with latest results.

- don't add listener that resizes composite to paint events, there are
too many of them, and one shouldn't try to resize/set bounds on paint,
that can only cause more paint events
- use CTabFolder2Listener.itemsCount to update on editor open/close
- use control listener to get updates on resize
- requires SWT 3.124.0

Fixes eclipse-platform#708
@iloveeclipse iloveeclipse merged commit 2fd96fa into eclipse-platform:master Apr 12, 2023
9 of 12 checks passed
@iloveeclipse iloveeclipse deleted the issue_708 branch April 12, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing views with empty editor area slow, shows paint artifacts
1 participant